Each start key fix #297
Merged
Each start key fix #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #291 |
Not Duplicate. (see fix each() start key) how i can remove this commit(of master branch) from another branch ? |
|
@ziaratban by rebasing. |
ziaratban
force-pushed
the
each-start-key-fix
branch
from
94d99c3 to
41b687c
Compare
foreach($cursor as $i => $v) exit($i); #return 1 -> bug ...
ziaratban
force-pushed
the
each-start-key-fix
branch
from
41b687c to
d3853fc
Compare
|
Could likely cause issues with current code in case it relies on indexes. Should be released in 2.2. |
|
@ziaratban would you please add a line for CHANGELOG.md? |
samdark
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start index in each() method is
1.now start from
0.